Skip to content

Update remarks for Enviroment.OSVersion #8996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2023
Merged

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 4, 2023

Enviroment.OSVersion does not return the actual OS version in some compatibility modes.

Fixes dotnet/runtime#85758

@jkotas jkotas requested a review from a team as a code owner May 4, 2023 14:41
@ghost ghost assigned jkotas May 4, 2023
@ghost ghost added the area-System.Runtime label May 4, 2023
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"More" seems a little vague to me. How about "most" or "most but not all"?

@learn-build-service-prod
Copy link

Learn Build status updates of commit 8eccded:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 8d1b750:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren enabled auto-merge (squash) May 5, 2023 16:10
@learn-build-service-prod
Copy link

Learn Build status updates of commit 033e824:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit d738809 into dotnet:main May 5, 2023
@jkotas jkotas deleted the issue-33643 branch May 5, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 6 Environment.OSVersion returns compatibility mode version
3 participants