Skip to content

Conversation

gewarren
Copy link
Contributor

Enables nullability in 50 C# projects.
Also removes a few BinaryFormatter examples.

Fixes #8986.

@gewarren gewarren requested a review from a team as a code owner May 18, 2023 04:27
@ghost ghost assigned gewarren May 18, 2023
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label May 18, 2023
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work @gewarren

I had a few optional suggestions. You should decide which style best illustrates the sample, then let's :shipit:

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link

Learn Build status updates of commit c93d5e8:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/Microsoft.Extensions.DependencyModel/DependencyContext/Overview/DependencyContextSnippets.csproj ✅Succeeded
snippets/csharp/Microsoft.SqlServer.Server/SqlFunctionAttribute/Function.csproj ✅Succeeded
snippets/csharp/Microsoft.SqlServer.Server/SqlUserDefinedAggregateAttribute/Aggregate.csproj ✅Succeeded
snippets/csharp/Microsoft.SqlServer.Server/SqlUserDefinedTypeAttribute/Type.csproj ✅Succeeded
snippets/csharp/Microsoft.SqlServer.Server/SqlUserDefinedTypeAttribute/Type1.cs ✅Succeeded
snippets/csharp/System.Collections.Immutable/ImmutableArray`1/Overview/ImmutableArraySnippets.csproj ✅Succeeded
snippets/csharp/System.DateTime/DateWithTimeZone.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.DateTime/Persistence.cs ✅Succeeded View
snippets/csharp/System.DateTime/SystemDateTimeReference.csproj ✅Succeeded
snippets/csharp/System.Diagnostics.Tracing/EventSource/Overview/etwtracesmall.csproj ✅Succeeded
snippets/csharp/System.Globalization/CultureInfo/CurrentCulture/changeculture1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Globalization/CultureInfo/CurrentCulture/changeculture11.cs ✅Succeeded View
snippets/csharp/System.Globalization/CultureInfo/CurrentCulture/currentculture.csproj ✅Succeeded
snippets/csharp/System.Globalization/JapaneseCalendar.ToDateTime/todatetime.csproj ✅Succeeded
snippets/csharp/System.IO/BinaryReader/Overview/BinaryReaderWriter.csproj ✅Succeeded
snippets/csharp/System.IO/Path/Combine/misc.csproj ✅Succeeded
snippets/csharp/System.IO/Path/Combine/pathcombine.cs ✅Succeeded View
snippets/csharp/System.IO/Path/DirectorySeparatorChar/directoryseparatorchar.csproj ✅Succeeded
snippets/csharp/System.IO/Path/GetFullPath/getfullpath.csproj ✅Succeeded
snippets/csharp/System.IO/Path/IsPathRooted/ispathrooted.csproj ✅Succeeded
snippets/csharp/System.IO/Path/TryJoin/tryjoin.csproj ✅Succeeded
snippets/csharp/System.Net.Http/HttpClientHandler/Overview/system.net.http.httpclienthandler.csproj ✅Succeeded
snippets/csharp/System.Net.Http/HttpClientHandler/ServerCertificateCustomValidationCallback/program.cs ✅Succeeded View
snippets/csharp/System.Net.Http/HttpClientHandler/ServerCertificateCustomValidationCallback/system.net.http.httpclienthandler-secure.csproj ✅Succeeded
snippets/csharp/System.Net.Http/SocketsHttpHandler/ConnectCallback/system.net.http.httpclienthandler-secure.csproj ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 73e5041 into dotnet:main May 18, 2023
@gewarren gewarren deleted the nrt1 branch May 18, 2023 20:11
@gewarren
Copy link
Contributor Author

Thanks @BillWagner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code snippets to use NRT
2 participants