Skip to content

Conversation

JeremyKuhne
Copy link
Member

It isn't obvious from the API name that Clear doesn't reset the color, it applies it. Adding an additional remark to help clarify.

dotnet/winforms#9301

@JeremyKuhne JeremyKuhne requested a review from a team as a code owner June 22, 2023 17:18
@ghost ghost assigned JeremyKuhne Jun 22, 2023
@ghost ghost added the area-System.Drawing label Jun 22, 2023
@ghost
Copy link

ghost commented Jun 22, 2023

Tagging subscribers to this area: @dotnet/area-system-drawing
See info in area-owners.md if you want to be subscribed.

Issue Details

It isn't obvious from the API name that Clear doesn't reset the color, it applies it. Adding an additional remark to help clarify.

dotnet/winforms#9301

Author: JeremyKuhne
Assignees: JeremyKuhne
Labels:

area-System.Drawing

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit b0bab8f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Drawing/Graphics.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren
Copy link
Contributor

@JeremyKuhne I couldn't leave a suggestion, so I committed directly. Hope you don't mind. I thought that the text you added should come first in the remarks section.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 727a50e:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Drawing/Graphics.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren enabled auto-merge (squash) September 14, 2023 21:13
@learn-build-service-prod
Copy link

Learn Build status updates of commit 495e037:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Drawing/Graphics.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 6190dd8 into main Sep 14, 2023
@gewarren gewarren deleted the JeremyKuhne-patch-1 branch September 14, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants