Skip to content

DynamicMethod permit ref returns in .NET Core 2.1+ #9335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2023
Merged

DynamicMethod permit ref returns in .NET Core 2.1+ #9335

merged 2 commits into from
Sep 27, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Sep 26, 2023

@jkotas jkotas requested a review from a team as a code owner September 26, 2023 23:03
@ghost ghost assigned jkotas Sep 26, 2023
@jkotas jkotas mentioned this pull request Sep 26, 2023
Closed
@learn-build-service-prod
Copy link

Learn Build status updates of commit 3bd2b68:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection.Emit/DynamicMethod.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

gewarren
gewarren approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in preview: https://review.learn.microsoft.com/en-us/dotnet/api/system.reflection.emit.dynamicmethod.-ctor?view=net-8.0&branch=pr-en-us-9335#system-reflection-emit-dynamicmethod-ctor(system-string-system-type-system-type())

buyaa-n
buyaa-n approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jkotas
jkotas commented Sep 27, 2023
View reviewed changes
@learn-build-service-prod
Copy link

Learn Build status updates of commit 93919dd:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection.Emit/DynamicMethod.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@jkotas jkotas merged commit 839b83c into dotnet:main Sep 27, 2023
@jkotas jkotas deleted the runtime-92670 branch September 27, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarren gewarren gewarren approved these changes

@steveharter steveharter Awaiting requested review from steveharter

+1 more reviewer

@buyaa-n buyaa-n buyaa-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkotas jkotas

Labels

area-System.Reflection.Emit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Relax DynamicMethod to permit ref returns

3 participants

@jkotas @gewarren @buyaa-n