Skip to content

Conversation

lemonez
Copy link
Contributor

@lemonez lemonez commented Sep 27, 2023

Summary

  • Fixed a typo in the ValidationAttribute.xml docstring.
  • There is also a typo in xml/System/String.xml#L7202 ("An parameter...") but when I try to fix it, it reformats the whole file because of a line ending issue or something, and I haven't been able to circumvent that either locally or in the GitHub UI.

@lemonez lemonez requested a review from ajcvickers as a code owner September 27, 2023 17:15
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.ComponentModel.DataAnnotations labels Sep 27, 2023
@ghost
Copy link

ghost commented Sep 27, 2023

Tagging subscribers to this area: @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

  • Fixed a typo in the ValidationAttribute.xml docstring.
  • There is also a typo in xml/System/string.xml ("An parameter...") but when I try to fix it, it reformats the whole file because of a line ending issue or something, and I haven't been able to circumvent that either locally or in the GitHub UI.
Author: lemonez
Assignees: -
Labels:

area-System.ComponentModel.DataAnnotations, community-contribution

Milestone: -

@learn-build-service-prod
Copy link

Learn Build status updates of commit b8a57b4:

✅ Validation status: passed

File Status Preview URL Details
xml/System.ComponentModel.DataAnnotations/ValidationAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren
Copy link
Contributor

it reformats the whole file because of a line ending issue or something, and I haven't been able to circumvent that either locally or in the GitHub UI.

@lemonez Don't worry about that, we see it a lot. There's a tool we use that unfortunately also changes the line endings, so it's normal that they get changed back on simple edits like yours.

@gewarren gewarren merged commit 6a82ff0 into dotnet:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.ComponentModel.DataAnnotations community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants