-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Updated HttpUtility ParseQueryString code snippets for C# and VB #9342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated HttpUtility ParseQueryString code snippets for C# and VB #9342
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsSummaryFixes #9251 This pull request enhances the C# and VB language examples on the HttpUtility.ParseQueryString page. Following a discussion with @MichaelDeutschCoding, I've introduced two updated versions of the code to replace the outdated examples that did not adhere to clean code principles. Thanks @gewarren and @carlossanlop for guiding me!
|
@dotnet-policy-service agree |
This comment was marked as outdated.
This comment was marked as outdated.
Hi @Rick-Anderson, @carlossanlop! Any news on this one? |
Hi guys @Rick-Anderson, @carlossanlop. It's been a month with no response, could you take a look at this one? Some feedback would be really appreciated! 😁 |
File Status Preview URL ms.author ms.prod ms.technology ms.service ms.subservice Details snippets/csharp/VS_Snippets_WebNet/HttpUtility_ParseQueryString/cs/httputility_parsequerystring.aspx Succeeded n/a (file deleted or renamed) |
Is this something that I have to solve? Everything seems to be success and I don't have access to most of the files. Anything I can do? |
Sorry for the late response. @gewarren is the main contact for this repo, she can help review. @Rick-Anderson since you own System.Web, can you also please take a look?
The CI passed, those are succeeded validation results, you don't need to do anything else for now. This now needs a code review. |
@JoanGil The Try.NET snippet fails with these errors when I preview it in the browser (you won't have permissions to do that unfortunately): program.cs(4,1): error CS0825: The contextual keyword 'var' may only appear within a local variable declaration or in script code |
Okay, I have updated the code, wrapping it inside a Program and Main. Hopefully this will solve the C# and VB problems. Could you check again @gewarren. Thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
Learn Build status updates of commit d4f906e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works now; thanks @JoanGil!
Summary
Fixes #9251
This pull request enhances the C# and VB language examples on the HttpUtility.ParseQueryString page. Following a discussion with @MichaelDeutschCoding, I've introduced two updated versions of the code to replace the outdated examples that did not adhere to clean code principles.
Thanks @gewarren and @carlossanlop for guiding me!