Skip to content

Conversation

eduardo-vp
Copy link
Member

@eduardo-vp eduardo-vp commented Sep 29, 2023

The Name property can now be renamed (doesn't throw an exception anymore). Based on the changes here dotnet/runtime#47084

Fixes dotnet/runtime#85635

@eduardo-vp eduardo-vp requested review from a team and kouvel as code owners September 29, 2023 16:51
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Threading labels Sep 29, 2023
@eduardo-vp
Copy link
Member Author

eduardo-vp commented Sep 29, 2023

I removed the code samples. However I'm not sure if the property can now be considered simple enough for this or if it should still have a sample code

@learn-build-service-prod

This comment was marked as outdated.

@ghost ghost added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Oct 2, 2023
@learn-build-service-prod
Copy link

Learn Build status updates of commit 3021b26:

✅ Validation status: passed

File Status Preview URL Details
snippets/cpp/VS_Snippets_CLR_System/system.Threading.Thread.Name/CPP/source.cpp ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Threading/Thread/Name/Project.csproj ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Threading/Thread/Name/source.cs ✅Succeeded n/a (file deleted or renamed)
snippets/fsharp/System.Threading/Thread/Name/fs.fsproj ✅Succeeded n/a (file deleted or renamed)
snippets/fsharp/System.Threading/Thread/Name/source.fs ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CLR_System/system.Threading.Thread.Name/VB/source.vb ✅Succeeded n/a (file deleted or renamed)
xml/System.Threading/Thread.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eduardo-vp!

@gewarren gewarren merged commit 1c81e4b into dotnet:main Oct 3, 2023
@eduardo-vp eduardo-vp deleted the update-thread-name branch May 29, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Threading community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec update for Thread.Name property

2 participants