Add best practice for avoiding native symbol name collisions #9484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
requested review from
AaronRobinsonMSFT and
jkoritzinsky
as code owners
jkotas
requested review from
MichalStrehovsky
and removed request for
AaronRobinsonMSFT and
jkoritzinsky
ghost
assigned
|
Cc @dotnet/interop-contrib |
|
Learn Build status updates of commit 53b049c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
This LGTM.
Should have pinged @gewarren for smithing previously.
xml/System.Runtime.InteropServices/UnmanagedCallersOnlyAttribute.xml
Outdated
Show resolved
Hide resolved
…te.xml Co-authored-by: Aaron Robinson <arobins@microsoft.com>
|
Learn Build status updates of commit bb9e354: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
AaronRobinsonMSFT
approved these changes
Dec 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on dotnet/runtime#95421