Skip to content

Conversation

SanderSade
Copy link
Contributor

Summary

Clarified what the static method means in the context of Regex.CacheSize. Current documentation is ambiguous, making it look like the discussion is about static C# methods and not Regex,Match/IsMatch/Replace/etc methods.

@SanderSade SanderSade requested a review from a team as a code owner January 5, 2024 13:05
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Text.RegularExpressions labels Jan 5, 2024
@ghost
Copy link

ghost commented Jan 5, 2024

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Clarified what the static method means in the context of Regex.CacheSize. Current documentation is ambiguous, making it look like the discussion is about static C# methods and not Regex,Match/IsMatch/Replace/etc methods.

Author: SanderSade
Assignees: -
Labels:

area-System.Text.RegularExpressions, community-contribution

Milestone: -

Copy link

Learn Build status updates of commit fe3376b:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.RegularExpressions/Regex.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@SanderSade
Copy link
Contributor Author

Gentle ping on @dotnet/area-system-text-regularexpressions members.

This comment was marked as outdated.

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

Copy link

Learn Build status updates of commit 102c05d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.RegularExpressions/Regex.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren enabled auto-merge (squash) January 19, 2024 18:23
Copy link

Learn Build status updates of commit d67a944:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.RegularExpressions/Regex.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 709adf9 into dotnet:main Jan 19, 2024
@SanderSade SanderSade deleted the patch-1 branch January 22, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Text.RegularExpressions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants