Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Mar 5, 2024

Add missing project files and fix some warnings. Also modernize code.

Copy link

Learn Build status updates of commit be58c9c:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Messaging/MessageQueue/.ctor/class1.cs ✅Succeeded View
snippets/csharp/System.Messaging/MessageQueue/.ctor/class11.cs ✅Succeeded View
snippets/csharp/System.Messaging/MessageQueue/.ctor/mqctor_denysharedreceive.cs ✅Succeeded View
snippets/csharp/System.Messaging/MessageQueue/.ctor/Project.csproj ✅Succeeded
snippets/csharp/System.Messaging/MessageQueue/BeginPeek/mqbeginpeek_noparms.cs ✅Succeeded View
snippets/csharp/System.Messaging/MessageQueue/BeginPeek/mqbeginpeek_timeout.cs ✅Succeeded View
snippets/csharp/System.Messaging/MessageQueue/BeginPeek/mqbeginpeek_timeoutstateobject.cs ✅Succeeded View
snippets/csharp/System.Messaging/MessageQueue/BeginPeek/Project.csproj ✅Succeeded
snippets/csharp/System.Net.Sockets/MulticastOption/Overview/listener.cs ✅Succeeded View
snippets/csharp/System.Net.Sockets/MulticastOption/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.Net.Sockets/MulticastOption/Overview/sender.cs ✅Succeeded View
snippets/csharp/System.Reflection.Emit/EnumBuilder/GetCustomAttributes/enumbuilder_setcustomattribute2.cs ✅Succeeded View
snippets/csharp/System.Reflection.Emit/EnumBuilder/GetCustomAttributes/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.InteropServices/ComImportAttribute/Overview/codefile1.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Runtime.InteropServices/ComImportAttribute/Overview/codefile2.cs ✅Succeeded View
snippets/csharp/System.Runtime.InteropServices/ComImportAttribute/Overview/codefile3.cs ✅Succeeded View
snippets/csharp/System.Runtime.InteropServices/ComImportAttribute/Overview/codefile4.cs ✅Succeeded View
snippets/csharp/System.Runtime.InteropServices/ComImportAttribute/Overview/codefile5.cs ✅Succeeded View
snippets/csharp/System.Runtime.InteropServices/ComImportAttribute/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.Runtime.InteropServices/Marshal/GetActiveObject/Project.csproj ✅Succeeded
snippets/csharp/System.Security.Cryptography/AsymmetricKeyExchangeDeformatter/Overview/contosodeformatter.cs ✅Succeeded View
snippets/csharp/System.Security.Cryptography/AsymmetricKeyExchangeDeformatter/Overview/ContosoEncryption.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Security.Cryptography/AsymmetricKeyExchangeDeformatter/Overview/makefile ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.Security.Cryptography/AsymmetricKeyExchangeDeformatter/Overview/Project.csproj ✅Succeeded
snippets/csharp/System.Windows.Forms/KeyPressEventArgs/Handled/Project.csproj ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thias LGTM @gewarren

Let's :shipit:

@gewarren
Copy link
Contributor Author

gewarren commented Mar 6, 2024

@BillWagner Can you approve it so I can merge it?

@BillWagner
Copy link
Member

I accidentally clicked "comment" instead of "approve" earlier.

@gewarren gewarren merged commit 1e6666e into dotnet:main Mar 6, 2024
@gewarren gewarren deleted the misc-code-fixes branch March 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants