Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren requested a review from mklement0 March 15, 2024 18:31
@gewarren gewarren requested a review from a team as a code owner March 15, 2024 18:31
@ghost ghost added the area-System.Runtime label Mar 15, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime

@mklement0
Copy link

Looks great for https://learn.microsoft.com/en-us/dotnet/api/system.environment, but you don't think the same remarks about the relationship with native libraries should be added to https://learn.microsoft.com/en-us/dotnet/fundamentals/runtime-libraries/system-environment-getenvironmentvariable as well?

@gewarren
Copy link
Contributor Author

Looks great for https://learn.microsoft.com/en-us/dotnet/api/system.environment, but you don't think the same remarks about the relationship with native libraries should be added to https://learn.microsoft.com/en-us/dotnet/fundamentals/runtime-libraries/system-environment-getenvironmentvariable as well?

@mklement0 Yes, I do, but it's a separate repo, so separate PR: dotnet/docs#40029.

Copy link

Learn Build status updates of commit afca483:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 2fd6c8c:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Environment.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

I had a similar question as the related PR, once you decide what to do, let's :shipit:

@gewarren gewarren merged commit 608537c into dotnet:main Mar 20, 2024
@gewarren gewarren deleted the set-ev branch March 20, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants