Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Mar 20, 2024

Fixes #9751.

(Hide whitespace changes.)

@gewarren
Copy link
Contributor Author

gewarren commented Mar 20, 2024

@davidbritch Can you review?

This comment was marked as outdated.

Copy link

@davidbritch davidbritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good to finally get a load of long deprecated Xamarin products out of the API docs.

@gewarren gewarren enabled auto-merge (squash) March 20, 2024 16:43
Copy link

Learn Build status updates of commit b11f46b:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Diagnostics/ProcessModuleCollection.xml ⚠️Warning View Details
xml/System.Globalization/CompareInfo.xml ⚠️Warning View Details
xml/System.Globalization/CultureInfo.xml ⚠️Warning View Details
xml/System.Globalization/DateTimeFormatInfo.xml ⚠️Warning View Details
xml/System.Globalization/RegionInfo.xml ⚠️Warning View Details
xml/System.Net.WebSockets/ClientWebSocketOptions.xml ⚠️Warning View Details
xml/System.Net.WebSockets/HttpListenerWebSocketContext.xml ⚠️Warning View Details
xml/System.Net/HttpListenerTimeoutManager.xml ⚠️Warning View Details
xml/System.Security.Cryptography/CngKey.xml ⚠️Warning View Details
xml/System.ServiceModel.Security/SecureConversationVersion.xml ⚠️Warning View Details
xml/System.ServiceModel.Security/SecurityPolicyVersion.xml ⚠️Warning View Details
xml/System.ServiceModel.Security/SecurityVersion.xml ⚠️Warning View Details
xml/System.ServiceModel.Security/TrustVersion.xml ⚠️Warning View Details
xml/System.ServiceModel/HttpBindingBase.xml ⚠️Warning View Details
xml/System/Uri.xml 💡Suggestion View Details
xml/FrameworksIndex/xamarinandroid-7.1.xml ✅Succeeded n/a (file deleted or renamed)
xml/FrameworksIndex/xamarinios-10.8.xml ✅Succeeded n/a (file deleted or renamed)
xml/FrameworksIndex/xamarinmac-3.0.xml ✅Succeeded n/a (file deleted or renamed)
xml/index.xml ✅Succeeded
xml/Microsoft.CSharp.RuntimeBinder/RuntimeBinderException.xml ✅Succeeded View
xml/Microsoft.CSharp.RuntimeBinder/RuntimeBinderInternalCompilerException.xml ✅Succeeded View
xml/Microsoft.SqlServer.Server/InvalidUdtException.xml ✅Succeeded
xml/Microsoft.Win32.SafeHandles/SafeMemoryMappedFileHandle.xml ✅Succeeded View
xml/System.Collections.Generic/Dictionary`2.xml ✅Succeeded View
xml/System.Collections.Generic/HashSet`1.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.Diagnostics/ProcessModuleCollection.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.Diagnostics/ProcessModuleCollection.xml with URL /dotnet/api/system.diagnostics.processmodulecollection.add was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Diagnostics/ProcessModuleCollection.xml with URL /dotnet/api/system.diagnostics.processmodulecollection.insert was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Diagnostics/ProcessModuleCollection.xml with URL /dotnet/api/system.diagnostics.processmodulecollection.remove was deleted without redirection. To avoid broken links, add a redirection.

xml/System.Globalization/CompareInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/CultureInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/DateTimeFormatInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Globalization/RegionInfo.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'format' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Net.WebSockets/ClientWebSocketOptions.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.Net.WebSockets/ClientWebSocketOptions.xml with URL /dotnet/api/system.net.websockets.clientwebsocketoptions.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/System.Net.WebSockets/HttpListenerWebSocketContext.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.Net.WebSockets/HttpListenerWebSocketContext.xml with URL /dotnet/api/system.net.websockets.httplistenerwebsocketcontext.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/System.Net/HttpListenerTimeoutManager.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.Net/HttpListenerTimeoutManager.xml with URL /dotnet/api/system.net.httplistenertimeoutmanager.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/System.Security.Cryptography/CngKey.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.Security.Cryptography/CngKey.xml with URL /dotnet/api/system.security.cryptography.cngkey.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/System.ServiceModel.Security/SecureConversationVersion.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.ServiceModel.Security/SecureConversationVersion.xml with URL /dotnet/api/system.servicemodel.security.secureconversationversion.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/System.ServiceModel.Security/SecurityPolicyVersion.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.ServiceModel.Security/SecurityPolicyVersion.xml with URL /dotnet/api/system.servicemodel.security.securitypolicyversion.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/System.ServiceModel.Security/SecurityVersion.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.ServiceModel.Security/SecurityVersion.xml with URL /dotnet/api/system.servicemodel.security.securityversion.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/System.ServiceModel.Security/TrustVersion.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.ServiceModel.Security/TrustVersion.xml with URL /dotnet/api/system.servicemodel.security.trustversion.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/System.ServiceModel/HttpBindingBase.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.ServiceModel/HttpBindingBase.xml with URL /dotnet/api/system.servicemodel.httpbindingbase.-ctor was deleted without redirection. To avoid broken links, add a redirection.

xml/System/Uri.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#IFormattable#ToString(System.String,System.IFormatProvider) for uid: System.Uri.System#IFormattable#ToString(System.String,System.IFormatProvider).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider) for uid: System.Uri.System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren merged commit 252b59a into dotnet:main Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up remaining Xamarin monikers/parameters

2 participants