Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document issues with using * in AssemblyVersion #9892

Merged
merged 4 commits into from
May 24, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented May 9, 2024

Summary

Document issues caused by using * in AssemblyVersion.

@tmat
Copy link
Member Author

tmat commented May 9, 2024

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

xml/System.Reflection/AssemblyVersionAttribute.xml Outdated Show resolved Hide resolved
xml/System.Reflection/AssemblyVersionAttribute.xml Outdated Show resolved Hide resolved
xml/System.Reflection/AssemblyVersionAttribute.xml Outdated Show resolved Hide resolved
xml/System.Reflection/AssemblyVersionAttribute.xml Outdated Show resolved Hide resolved
xml/System.Reflection/AssemblyVersionAttribute.xml Outdated Show resolved Hide resolved
xml/System.Reflection/AssemblyVersionAttribute.xml Outdated Show resolved Hide resolved

This comment was marked as outdated.

Copy link
Contributor

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way the IDE support can tip users off when E&C fails due to * in the version attributes? Instead of just saying the value changed, call out a URL where users can learn what to do instead to fix E&C.

@tmat
Copy link
Member Author

tmat commented May 10, 2024

@AArnott
Definitely. IN some cases we report better error but other cases fail with error message that's not very useful. Will follow up on that.

tmat and others added 2 commits May 16, 2024 09:06
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 694eb8a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/AssemblyVersionAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Copy link

Learn Build status updates of commit 770a3e1:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/AssemblyVersionAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 13f97b8 into dotnet:main May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants