Update base image of 5.0 SDK for Alpine and Nano #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
A couple overall comments.
- I don't see a technical reason why this couldn't be back-ported to 3.1. It doesn't appear to be a breaking change. It seems like a risk and ROI question.
- Because we don't have a standalone SDK and are selecting the individual components to copy to the final image, I feel there is some risk with missing components. For example the SDK adds another directory. A possible mitigation to this risk would be to have a unit test that compares the SDK zip/tarball contents against our SDK image. Thoughts?
|
I'll log an issue to add a test as a separate task so that it can take advantage of the changes in #1743. |
| @@ -31,10 +33,16 @@ RUN $powershell_version = '7.0.0'; ` | |||
| Remove-Item -Force PowerShell.Windows.x64.$powershell_version.nupkg; ` | |||
| Remove-Item -Path \powershell\.store\powershell.windows.x64\$powershell_version\powershell.windows.x64\$powershell_version\powershell.windows.x64.$powershell_version.nupkg -Force | |||
|
|
|||
| # Delete everything in the dotnet folder that's not needed in the SDK layer | |||
There was a problem hiding this comment.
I feel like not needed in the SDK layer should be clarified here. I don't want to give the impression the content isn't in the resulting SDK image. I'm not sure how to word this.
Suggested change
| # Delete everything in the dotnet folder that's not needed in the SDK layer | |
| # Delete the dotnet content that is not contained within the aspnet base layers. |
MichaelSimons
approved these changes
Apr 14, 2020
This was referenced Apr 16, 2020
mthalman
added a commit
to mthalman/dotnet-docker
that referenced
this pull request
Apr 23, 2020
mthalman
added a commit
to mthalman/dotnet-docker
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow for more layer sharing amongst images, the 5.0 SDK images for Alpine and Nano Server have been changed to be based on their respective ASP.NET images. This requires that the runtime and ASP.NET components of the SDK be omitted when extracting its contents since they are derived from base layers.
Fixes #1351