Skip to content

Extracted IResourceWatcherMetrics interface for mocking in unit tests #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2023
Merged

Extracted IResourceWatcherMetrics interface for mocking in unit tests #526

merged 4 commits into from
Feb 10, 2023

Conversation

tomasfabian
Copy link
Contributor

@tomasfabian tomasfabian commented Feb 9, 2023 •
edited
Loading

This PR enables testability for the ResourceWatcher<TEntity> class see also #523 by extracting a new interface IResourceWatcherMetrics<TEntity>.

@buehler
Copy link
Collaborator

buehler commented Feb 10, 2023

Hey @tomasfabian

Thank you so much! Nice work, thanks for providing contributions to this project :-)

@buehler buehler merged commit 6da41bd into dotnet:master Feb 10, 2023
@tomasfabian tomasfabian mentioned this pull request Feb 10, 2023
Merged
@tomasfabian
Copy link
Contributor Author

Hey @tomasfabian

Thank you so much! Nice work, thanks for providing contributions to this project :-)

You are welcome and thank you, too!

buehler added a commit that referenced this pull request Feb 14, 2023
@tomasfabian @buehler
test: Improved ResourceWatcher restart unit test (#527)
5a37536 
#482 #522 #523 #526

---------

Co-authored-by: Christoph Bühler <buehler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buehler buehler buehler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomasfabian @buehler