Parse out V1Status for code 422 on Reconcile loop of ManagedController #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2023 16:18
Give a little better message for errors returned by k8s (at least for code 422)
|
@buehler or @tomasfabian : |
buehler
requested changes
Apr 14, 2023
|
Thank you for the contribution :-) What do you think about my input for the log message? |
|
@buehler added a response ... lmk your thoughts and if you still want the change, I will do it |
|
Totally makes sense :-) |
buehler
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give a little better message for errors returned by k8s (at least for code 422).
K8S api will return a V1Status when the API rejects a call. This can be output to the users in the log