Move Testing code #340
Merged
Move Testing code #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Compilation.Abstractions
….Compilation.Abstractions
This fixes a build error related to missing 'BindingFlags' and 'GetMethod'
- avoids future problems related to aspnet/External#48 - e.g. when Travis updates default Mono version in `csharp` bundle
- use Ubuntu 14.04 (Trusty) - Travis support for Trusty is in Beta and currently requires `sudo` - run `dnu restore` with DNX Core since aspnet/External#49 is not fixed in Mono versions we can use - add required dependencies for DNX Core to `.travis.yml` - addresses part of aspnet/Universe#290
Link to xUnit's docs for version guidance
- #193 - previously relied on `OperatingSystem` string which can have many values - some xplat tests e.g. MVC repo on Mac are currently failing due to this bug - add `TestPlatformHelperTest` nits: - remove unused variable from `[OSSkipCondition]` - clean up some long lines - move `OSSkipConditionAttributeTest` to correct namespace - move `OSSkipConditionFacts` to correct project, fix its namespace and rename class
See aspnet/Announcements#144 for more information.
See aspnet/Announcements#144 for more information.
[auto-updated: dependencies]
|
Can we wait to discuss in eng triage first? We need to consider the broader impact of merging repos, e.g. servicing, CI, automation, etc. |
[auto-updated: dependencies]
[auto-updated: dependencies]
|
Let's bring this back and do it. |
pakrym
force-pushed
the
pakrym/Merge-testing
branch
from
81f4363 to
dff249a
Compare
pakrym
force-pushed
the
pakrym/Merge-testing
branch
from
dff249a to
43a6d7b
Compare
|
Builds and tests, ready for review. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.