Skip to content

Enable skipping member data rows #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2018
Merged

Enable skipping member data rows #354

merged 1 commit into from
May 10, 2018

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented May 9, 2018

Potential replacement for #352

@Tratcher Tratcher added this to the 2.2.0-mq milestone May 9, 2018
@Tratcher Tratcher self-assigned this May 9, 2018
@Tratcher Tratcher requested a review from pakrym May 9, 2018 22:28
pakrym
pakrym reviewed May 9, 2018
View reviewed changes
src/Microsoft.AspNetCore.Testing/xunit/ConditionalTheoryDiscoverer.cs Outdated
var obj = dataRow[0];
if (obj != null)
{
var t = obj.GetType();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give me more letters Chris.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

var theSystemDotTypeOfTheCurrentObject = obj.GetType();

@Tratcher Tratcher merged commit ad9f15f into dev May 10, 2018
@Tratcher Tratcher deleted the feature/skips branch May 10, 2018 17:30
@Tratcher Tratcher mentioned this pull request May 15, 2018
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesNK JamesNK JamesNK left review comments

+2 more reviewers

@pranavkm pranavkm pranavkm approved these changes

@pakrym pakrym pakrym approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
2.2.0-mq
Development

Successfully merging this pull request may close these issues.
4 participants
@Tratcher @pranavkm @JamesNK @pakrym