Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update M.E.AI code coverage mins from 0 #5698

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Update M.E.AI code coverage mins from 0 #5698

merged 6 commits into from
Nov 26, 2024

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Nov 26, 2024 •
edited by dotnet-policy-service bot
Loading

Based on #5640 (comment)

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner November 26, 2024 18:49
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 78
Microsoft.Extensions.AI.OpenAI 60 66
Microsoft.Extensions.AI.Ollama 75 80
Microsoft.Extensions.AI.Abstractions 80 83
Microsoft.Extensions.AI.AzureAIInference 70 77
Microsoft.Extensions.AI 80 83

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=880051&view=codecoverage-tab

@stephentoub
Copy link
Member Author

We want the limits to be this tightly coupled to the current coverage? It breeds zero breathing room. Does the tooling fail CI if the coverage drops below the minimum?

@RussKie
Copy link
Member

RussKie commented Nov 26, 2024

Does the tooling fail CI if the coverage drops below the minimum?

Yes

@RussKie
Copy link
Member

RussKie commented Nov 26, 2024

This code coverage step was always there, it just the reporting of the issues to GitHub was failing due infra issues.

For example:
image

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=880346&view=codecoverage-tab

@RussKie RussKie merged commit a7e1413 into dotnet:main Nov 26, 2024
6 checks passed
@RussKie
Copy link
Member

RussKie commented Nov 27, 2024

🎉 Good job! The coverage increased 🎉 Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 84
Full code coverage report: dev.azure.com/dnceng-public/public/_build/results?buildId=880346&view=codecoverage-tab

#5700 to address the remaining

@stephentoub stephentoub deleted the meaicoverage branch November 27, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RussKie RussKie RussKie approved these changes

Assignees

@stephentoub stephentoub

Labels
area-AI area-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @dotnet-comment-bot @RussKie