Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional tests to the logging generator #5704

Merged
merged 18 commits into from
Dec 4, 2024
Merged

Additional tests to the logging generator #5704

merged 18 commits into from
Dec 4, 2024

Conversation

rainsxng
Copy link
Contributor

@rainsxng rainsxng commented Nov 28, 2024 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 86

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=881898&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 86

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=882092&view=codecoverage-tab

@dariusclay dariusclay self-requested a review December 2, 2024 10:08
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 86
Microsoft.Extensions.AI.AzureAIInference 83 91

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=884761&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.AI.AzureAIInference 83 91
Microsoft.Extensions.Caching.Hybrid 75 86

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=884937&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Caching.Hybrid 75 78
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.AI.AzureAIInference 83 91

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=884976&view=codecoverage-tab

@rainsxng rainsxng linked an issue Dec 3, 2024 that may be closed by this pull request
Follow up to add additional tests to Logging generator #5436
Closed
@rainsxng rainsxng changed the title Dbohdanov/logger generator tests Tests for the TypeSymbolExtensions Dec 3, 2024
@rainsxng rainsxng changed the title Tests for the TypeSymbolExtensions Additional tests to the logging generator Dec 3, 2024
@rainsxng
Copy link
Contributor Author

rainsxng commented Dec 3, 2024

@dotnet-policy-service agree company="Microsoft"

@rainsxng rainsxng marked this pull request as ready for review December 3, 2024 16:06
@rainsxng rainsxng requested a review from a team as a code owner December 3, 2024 16:06
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.AI.AzureAIInference 83 91
Microsoft.Extensions.Caching.Hybrid 75 86

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=885055&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.AI 83 84
Microsoft.Extensions.Caching.Hybrid 75 86
Microsoft.Extensions.AI.AzureAIInference 83 91

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=885952&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 86
Microsoft.Extensions.AI 83 84
Microsoft.Extensions.AI.AzureAIInference 83 91

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=886017&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Caching.Hybrid 75 77
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.AI.AzureAIInference 83 91
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI 83 84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=886213&view=codecoverage-tab

@rainsxng rainsxng merged commit af32f59 into main Dec 4, 2024
6 checks passed
@rainsxng rainsxng deleted the dbohdanov/logger_generator_tests branch December 4, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariamgerges mariamgerges mariamgerges approved these changes

@dariusclay dariusclay dariusclay approved these changes

Assignees

@rainsxng rainsxng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow up to add additional tests to Logging generator
5 participants
@rainsxng @dotnet-comment-bot @dariusclay @mariamgerges @RussKie