Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage aggregation via Dictionary<string, long> #5709

Merged
merged 17 commits into from
Dec 4, 2024

Conversation

SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Dec 2, 2024

This is a much simpler version of #5707 in case we prefer this approach. It limits additional usage data to be of type long, with the payoff that we require much less implementation and new public API surface.

If we think this will suffice, it's certainly advantageous vs #5707. Arguably we could proceed with this as-is, and then in the future if further "additional usage" value types are needed, we'd still have the option to add some other property called AdditionalValues (or similar) to UsageDetails which accepts a wider range of types.

Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 83 84
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 86

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=883335&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 86
Microsoft.Extensions.AI.AzureAIInference 83 91
Microsoft.Extensions.AI 83 84
Microsoft.Extensions.AI.Abstractions 83 84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=885946&view=codecoverage-tab

@SteveSandersonMS SteveSandersonMS enabled auto-merge (squash) December 4, 2024 11:08
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 86
Microsoft.Extensions.AI.AzureAIInference 83 91
Microsoft.Extensions.AI.Abstractions 83 84
Microsoft.Extensions.AI 83 84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=886016&view=codecoverage-tab

@SteveSandersonMS SteveSandersonMS merged commit 9341356 into main Dec 4, 2024
6 checks passed
@SteveSandersonMS SteveSandersonMS deleted the stevesa/usage-aggregation-simple-dict branch December 4, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants