Fix handling of text-only user messages in AzureAIInferenceChatClient #5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ChatRequestUserMessage` has three constructors: ```csharp public ChatRequestUserMessage(string content) public ChatRequestUserMessage(IEnumerable<ChatMessageContentItem> content) public ChatRequestUserMessage(params ChatMessageContentItem[] content) ``` but even though all of the parameters are named `content` and represent the message's content, they behave differently. The first assigns the string content to the instance's `Content` property and leaves its `MultimodalContentItems` property null, and the others leave `Content` null and set `MultimodalContentItems` to the property. For models that don't support multi-modal, using the latter two constructors breaks, even when the content is a single text item. I think this should be improved in Azure.AI.Inference, but regardless, this fixes the ToAzureAIInferenceChatMessages helper to special-case text-only inputs and use the first `string`-based constructor rather than always using the `IEnumerable<ChatMessageContentItem>`-based one.
|
cc: @trangevi |
src/Libraries/Microsoft.Extensions.AI.AzureAIInference/AzureAIInferenceChatClient.cs
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Dec 2, 2024
|
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=884548&view=codecoverage-tab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatRequestUserMessagehas three constructors:but even though all of the parameters are named
contentand represent the message's content, they behave differently. The first assigns the string content to the instance'sContentproperty and leaves itsMultimodalContentItemsproperty null, and the others leaveContentnull and setMultimodalContentItemsto the property. For models that don't support multi-modal, using the latter two constructors breaks, even when the content is a single text item.I think this should be improved in Azure.AI.Inference, but regardless, this fixes the ToAzureAIInferenceChatMessages helper to special-case text-only inputs and use the first
string-based constructor rather than always using theIEnumerable<ChatMessageContentItem>-based one.Fixes #5708
Microsoft Reviewers: Open in CodeFlow