Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UseLogging a nop when NullLoggerFactory is used #5717

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Make UseLogging a nop when NullLoggerFactory is used #5717

merged 1 commit into from
Dec 3, 2024

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Dec 3, 2024 •
edited by dotnet-policy-service bot
Loading

The hopefully non-controversial part of #5687

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner December 3, 2024 15:54
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.AI.AzureAIInference 83 91
Microsoft.Extensions.Caching.Hybrid 75 84
Microsoft.Extensions.AI 83 84

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=885038&view=codecoverage-tab

@stephentoub stephentoub merged commit e8efa1f into dotnet:main Dec 3, 2024
6 checks passed
@stephentoub stephentoub deleted the noplogging branch December 3, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@stephentoub stephentoub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @dotnet-comment-bot @eiriktsarpalis