Fix Unicode characters being entered via console #13054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KevinRansom FYI - regression was in #6311 in March 2019 |
|
This is ready. |
|
lgtm |
vzarytovskii
approved these changes
Apr 27, 2022
|
@vzarytovskii Our script seems to work correctly when I debug it in VS 2019 (Microsoft (R) F# Interactive version 11.4.2.0 for F# 5.0). But when I run it from a .cmd file by calling When I replace Our issue involves File.ReadAllText and/or File.WriteAllText, so maybe it's not the same bug that this merge fixed. |
charlesroddie
pushed a commit
to charlesroddie/fsharp
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7733
I finally looked into this long standing regression.
This change between F# 4.5 and F# 4.7 was incorrect -
fixNonUnicodeSystemConsoleReadKeyis considered false in the change, but it appears someone falsely read!aasnot a. A good example of why it was good to deprecate!exprin F# 6.0I don't actually know how to test console key input within our automated testing, I'm not totally sure it can be done. None of console.fs is under automated test AFAIK. If anyone has good ideas we could add testing.