Skip to content

Extend TailCallChecks to cover a missing warnings regarding List.collect #16027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2023
Merged

Extend TailCallChecks to cover a missing warnings regarding List.collect #16027

merged 4 commits into from
Oct 9, 2023

Conversation

dawedawe
Copy link
Contributor

This extends the detection of CPS-like expressions to also allow warning about non-tailrec calls to List.collect, Array.collect, ...

@dawedawe dawedawe marked this pull request as ready for review September 22, 2023 20:15
@dawedawe dawedawe requested a review from a team as a code owner September 22, 2023 20:15
@T-Gro T-Gro merged commit f2b8306 into dotnet:main Oct 9, 2023
@dawedawe dawedawe deleted the missing_tailrec_warning branch October 9, 2023 18:55
@allisonchou allisonchou mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dawedawe @psfinaki @T-Gro @0101 @vzarytovskii