Skip to content

Clean up NicePrint #16086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2023
Merged

Clean up NicePrint #16086

merged 2 commits into from
Oct 9, 2023

Conversation

kerams
Copy link
Contributor

@kerams kerams commented Oct 7, 2023

No description provided.

@kerams kerams requested a review from a team as a code owner October 7, 2023 09:17
psfinaki
psfinaki reviewed Oct 9, 2023
View reviewed changes
src/Compiler/Utilities/sformat.fs
let keywordInline = tagKeyword "inline"
let keywordModule = tagKeyword "module"
let keywordNamespace = tagKeyword "namespace"
let punctuationUnit = tagPunctuation "()"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about parentheses?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or parens.

@vzarytovskii vzarytovskii enabled auto-merge (squash) October 9, 2023 09:58
@vzarytovskii vzarytovskii disabled auto-merge October 9, 2023 09:59
@vzarytovskii vzarytovskii merged commit 4934588 into dotnet:main Oct 9, 2023
@allisonchou allisonchou mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@psfinaki psfinaki psfinaki left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kerams @psfinaki @vzarytovskii