Skip to content

Conversation

auduchinok
Copy link
Member

Continuation of #18645. Fixes DeclaringEntity for members defined in an abbreviated type extension:

module Module

type d = System.Collections.Generic.IDictionary<int, int>

type d{caret} with
    member x.P = 1

Since these members are now being analyzed due to the added recovery, it gets to a state that was never explicitly supported and tested, and there are places that are not ready for it.

The problem I've encountered in the Rider plugin tests is P member above assumes it's defined in the actual IDicitionary type, not in Module.

Copy link
Contributor

github-actions bot commented Sep 16, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md

@auduchinok auduchinok force-pushed the auduchinok/checker-recovery-abbrExtensionEntity branch from 18352c2 to 48dfdad Compare September 17, 2025 10:51
Copy link
Contributor

@edgarfgp edgarfgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Sep 18, 2025
@T-Gro T-Gro merged commit 234ce6d into dotnet:main Sep 18, 2025
38 checks passed
@auduchinok auduchinok deleted the auduchinok/checker-recovery-abbrExtensionEntity branch September 18, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants