Miscellaneous test fixes #482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Assert.AreEqual([| [|1..4|]; [|5..8|] |], Array.chunkBySize 4 [|1..8|]) | ||
| Assert.AreEqual([| [|1..4|]; [|5..8|]; [|9..10|] |], Array.chunkBySize 4 [|1..10|]) | ||
| Assert.AreEqual([| [|1|]; [|2|]; [|3|]; [|4|] |], Array.chunkBySize 1 [|1..4|]) | ||
| Assert.IsTrue([| [|1..4|]; [|5..8|] |] = Array.chunkBySize 4 [|1..8|]) |
There was a problem hiding this comment.
are you sure we want this? The reporting will be worse if something breaks.
There was a problem hiding this comment.
It's not perfect, no. Failures will still have a stack pointing to the line that failed, though, so it's not too bad. And FWIW this is the pattern used for most of the tests already (due to the same reason, that older NUnit has broken AreEqual for complicated collections).
There was a problem hiding this comment.
rewriting tests in such a way because of an old test framework dependency, feels really like a bad idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to address bitrot in the tests - uncovered these as I am getting our internal test infrastructure running again.
NoMTtest tag to various new tests that don't support mixed .NET version testing (i.e. .NET 2/4 multitargeting)