Use Char.isDigit from .NET #6524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
reviewed
Apr 13, 2019
| if i >= len then failwithf "%s" <| FSComp.SR.forBadPrecision() | ||
| match fmt.[i] with | ||
| | c when isDigit c -> digitsPrecision (i+1) | ||
| | c when System.Char.IsDigit c -> digitsPrecision (i+1) |
There was a problem hiding this comment.
Maybe, open the namespace instead?
There was a problem hiding this comment.
More often than not we use System.Char.IsDigit in this codebase. It's not clear to me why.
There was a problem hiding this comment.
And amusingly @forki's PR does it both ways.
KevinRansom
approved these changes
Apr 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.