Added pin options, abstract class and I2C #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
joperezr
reviewed
Jan 2, 2019
joperezr
reviewed
Jan 2, 2019
joperezr
reviewed
Jan 4, 2019
krwq
reviewed
Jan 4, 2019
joperezr
reviewed
Jan 4, 2019
joperezr
reviewed
Jan 4, 2019
joperezr
approved these changes
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an abstract and separated for I2C and SPI.
Modified addressing approach to instantiate binding with device instead of being able to address multiple devices within Read/Write methods. This fits better with the connection settings.
Added controller pin options for reset and interrupt pins. Events are planned for future PR.
Updated samples and documentation.
See #88 for future details.