Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate device listing #1592

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Conversation

krwq
Copy link
Member

@krwq krwq commented Jul 16, 2021

Microsoft Reviewers: Open in CodeFlow

@krwq krwq requested a review from Ellerbach July 16, 2021 11:06
@@ -14,13 +14,21 @@ Our vision: the majority of .NET bindings are written completely in .NET languag

* [Adafruit Seesaw - extension board (ADC, PWM, GPIO expander)](Seesaw/README.md)
* [ADS1115 - Analog to Digital Converter](Ads1115/README.md)
* [Board abstraction](Board/README.md)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about board and arduino to display here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just put it in the protocole section like FT4222

@@ -227,34 +243,44 @@ Our vision: the majority of .NET bindings are written completely in .NET languag

### USB devices

* [Board abstraction](Board/README.md)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also mixed feelings about board being here (Arduino makes more sense here though)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just put all those elements into a protocole/USB section or equivalent


### Multi-device or robot kit

* [GoPiGo3](GoPiGo3/README.md)
* [GrovePi](GrovePi/README.md)
* [Sense HAT](SenseHat/README.md)
* [SensorHub - Environmental sensor](SensorHub/README.md)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps arduino and board should be just here and under protocols

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is fine, it's used with multi devices like the previous ones

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See little comment otherwise all good!

@krwq krwq merged commit 135b856 into dotnet:main Jul 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants