Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue when trying to run pack #1942

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Oct 3, 2022

Fixes #1940

cc: @pgrawehr

Microsoft Reviewers: Open in CodeFlow

@joperezr joperezr requested a review from pgrawehr October 3, 2022 23:49
Copy link
Contributor

@pgrawehr pgrawehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that indeed fixes it.

It's a bit ugly that our build is not really controlled by the default arguments to build.cmd. Many of the arguments specified in build /? don't work as expected (e.g. -test is ignored, because the tests always run), and other important ones are properties and therefore not documented.

@joperezr
Copy link
Member Author

joperezr commented Oct 4, 2022

Yup, that is a valid concern. build.cmd infrastructure mainly comes from Arcade, so that is what gets printed via help. Feel free to log an issue about having the script work as intended by arcade, and I'd be happy to fix it.

@joperezr joperezr merged commit 56b8372 into dotnet:main Oct 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master build is broken after Version updates
2 participants