Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Firmata 2.7 #2093

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Add support for Firmata 2.7 #2093

merged 2 commits into from
Jul 10, 2023

Conversation

pgrawehr
Copy link
Contributor

@pgrawehr pgrawehr commented Jul 2, 2023 •
edited
Loading

Add support for Firmata protocol version 2.7 (supported by ConfigurableFirmata 3.1)

  • Add support for new SystemVariable command
  • Add support for extended analog channels
  • Improve analog channel mapping support (previous implementation used confusing names)
Microsoft Reviewers: Open in CodeFlow

Ellerbach
Ellerbach approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pgrawehr pgrawehr merged commit cbf35d2 into dotnet:main Jul 10, 2023
@pgrawehr pgrawehr mentioned this pull request Oct 20, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ellerbach Ellerbach Ellerbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgrawehr @Ellerbach