Fix wrong PinCount evaluation for FT232H #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FT4232H has 8 pins per channel, both FT2232H and FT232H have 16 pins per channel
ghost
added
the
area-device-bindings
|
@Ellerbach may you have a look at this fix? |
Ellerbach
approved these changes
Aug 4, 2023
raffaeler
approved these changes
Aug 4, 2023
|
Is there anything i need to do to get the |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The pipeline failed with the following error:
I guess thats not a code problem and another run may be necesarry? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There is probably a different issue in the pipeline right now, but I am not sure retrying will suffice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to open pins 8-15 on a FT232H board using the Ft232HGpio driver, because the pin count checked against is the pin count of the device, which is set to 8 instead of 16.
This is caused because the type of the device is checked, but the assignment of the pin count is actually the wrong way around, e.g. FT4232H is assigned 16 pins per channel (instead of 8) and both FT232H and FT2232H are assigned 8 pins per channel (instead of 16).
Microsoft Reviewers: Open in CodeFlow