[generator] Process javadoc for nested types #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#992 Looking at the latest set of API docs for [a nested type][0] I noticed that we were missing a lot of content that should have been produced by the Mono.Android build when translating Javadoc to C# doc comments. After further investigation, we realized that we were not attempting to process and translate Javadoc for _any_ nested types. This has been fixed by adding a missing Javadoc processing iteration over each types nested type. Additionally, Java documentation URLs for nested types have been fixed by replacing '$' with '.' in both the URL and text for the URL. [0]: https://github.com/xamarin/android-api-docs/blame/b4084443c0354661e2257eb698e03d3fe1d86f1b/docs/Mono.Android/en/Android.AccessibilityServices/AccessibilityButtonController%2BAccessibilityButtonCallback.xml#L25
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #992
Looking at the latest set of API docs for a nested type I noticed
that we were missing a lot of content that should have been produced by
the Mono.Android build when translating Javadoc to C# doc comments.
After further investigation, we realized that we were not attempting to
process and translate Javadoc for any nested types. This has been
fixed by adding a missing Javadoc processing iteration over each types
nested type.
Additionally, Java documentation URLs for nested types have been fixed
by replacing '$' with '.' in both the URL and text for the URL.