An extra empty column is always shown in the datagrid for Data screen.

[rustd]

This is confusing as it appears that there is missing info. It also looks very unpolished

[rustd]

If this is coming up to fill the spacing, then we should reduce the column width to be as small as possible so this empty column is less visible in the short term.

[tbombach]

The WPF datagrid works this way by default - it uses an empty column to fill the empty space. I started looking into this (setting all columns to Width="*" or Width="Auto") but it didn't fix the issue. I also tried using AutoGenerateColumns = false but that also caused problems. We should look into it more, but I just wanted to update with what I've tried so far.

This also happens for the data preview grid too if the window is big enough. It's just that the data grid usually has wide enough columns that there's no extra space.

[rustd]

Thanks. ugh... As a work around could we change the behavior of the 2nd last column to take up the remaining width?

[tbombach]

Possible PR that we might want to take: https://github.com/dotnet/machinelearning-tools/pull/152

I think this solution looks better than what we have currently

[JakeRadMSFT]

Data not addressed but evaluate is. I don’t think we should do the same fix for data we want all the screen real estate we can get.

[JakeRadMSFT]

I’ll change this bug to be for data preview and remove ship blocker label.

[rustd]

Ok

…

On Mon, May 6, 2019 at 9:22 AM Jake ***@***.***> wrote: I’ll change this bug to be for data preview and remove ship blocker label. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/dotnet/machinelearning-tools/issues/143#issuecomment-489682187>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIUQ3AT5AID5DOI6N6AZD3PUBLN7ANCNFSM4HK4EH3Q> .

[IanMatthewHuff]

Resolving with the same fix as Thomas for the other grid. Posting my comments from teams here as well.

Maybe the design needs a tweak but from what I see Thomas' Fix for the top 5 evaluation is actually the correct fix here for the current design. As of now two things are set

1. Columns are set to auto size for the content, the long sentiment strings create a long column to hold them
2. The data grid is wrapped in a scroll container so it basically can grow unbounded horizontally but will wrap with an h - scroll if it goes too far.

Based on 1 and 2 you can't stretch out a column to fill the remaining length (which is probably what happened as it looks like Thomas might have tried out * sizing the last column to fix the issue). Due to the scroll container the grid width is not bound by the width of the containing control so telling it "use all remaining space" doesn't have the meaning that you expect it to. Jake mentioned that we want to use all screen real estate, but that doesn't really apply here as we already have the columns set to use as much space as they need to display their contents. If we left align the grid and there is space on the right then that is not wasted space, we simply don't have any rows long enough to require the entire width of the control currently. There isn't going to be anything hidden in that case.

1. Left align to get rid of the phantom stretch column like Thomas did for the other grid. 
2. Take the grid out of the scroll container, stretch it to fill the full screen width. Make the columns resizable and just try to fit them into that space as well as you can, this will always fill the full h real estate and will never have an h scroll bar. 
3. Hook the auto grid creation event. Resize the last column to full the full space if the used grid width < the width of the control above the scrollable control. Update that on any resizes. (I don't recommend this as I think it's error prone and not needed, but it is a possible option). Also not needed as in this case we are already displaying all of the grid row data.

[JakeRadMSFT]

Thanks Ian!

[rustd]

Thank you Ian!