Skip to content

fixing scenerio 3 of issue #3995 #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2019
Merged

fixing scenerio 3 of issue #3995 #4214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b1d1e5
fixing scenerio 3 of issue 3995
kere-nel Sep 13, 2019
8e1f4bf
Merge remote-tracking branch 'upstream/master'
kere-nel Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Microsoft.ML.LightGbm/LightGbmRankingTrainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ private protected override void CheckDataValid(IChannel ch, RoleMappedData data)
$"Label column '{labelCol.Name}' is of type '{labelType.RawType}', but must be Key or Single.");
}
// Check group types.
ch.CheckParam(data.Schema.Group.HasValue, nameof(data), "Need a group column.");
if(!data.Schema.Group.HasValue)
throw ch.ExceptValue(nameof(data.Schema.Group), "Group column is missing.") ;
Copy link

@yaeldekel yaeldekel Sep 15, 2019 •
edited by kere-nel
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if (!condition)
    throw ...

is the same as doing a check on condition.
#Resolved

Copy link
Contributor Author

@kere-nel kere-nel Sep 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yael! Checkparam throws an ArgumentOutOfRangeException, I switched to checking manually, so I can throw a different type of exception. There's also a checkvalue function, but it only works for checking classes. #Resolved

var groupCol = data.Schema.Group.Value;
var groupType = groupCol.Type;
if (!(groupType == NumberDataViewType.UInt32 || groupType is KeyDataViewType))
Expand Down