Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes onnx exports for binary classification trainers #4463

Open
wants to merge 10 commits into
base: master
from

Conversation

@Lynx1820
Copy link
Member

Lynx1820 commented Nov 9, 2019

This PR fixes the issues with exporting the following binary classification trainers to onnx:

  • SymbolicSgdLogisticRegression(),
  • SgdCalibrated(),
  • AveragedPerceptron(),
  • FastForest(),
  • LinearSvm(),
  • SdcaNonCalibrated(),
  • SgdNonCalibrated(),
  • FastTree(),
  • LbfgsLogisticRegression(),
  • Trainers.LightGbm(),
  • SdcaLogisticRegression(),
  • SgdCalibrated(),
  • SymbolicSgdLogisticRegression()

Note: I couldn't create consistent regression models, even when seeding, so I didn't include baseline comparison on these tests.

Update: Baseline files have changed. Waiting for @harishsk's PRs to go through before submitting my changes.

Lynx1820 added 3 commits Oct 31, 2019
This reverts commit 1ad45c995516b9d39fc05aca855ce2abe96c407b.
@Lynx1820 Lynx1820 requested a review from dotnet/mlnet-core as a code owner Nov 9, 2019
@Lynx1820 Lynx1820 requested review from ganik, harishsk and KsenijaS Nov 9, 2019
frank-dong-ms and others added 7 commits Nov 9, 2019
* nightly build pipeline
This reverts commit 1ad45c995516b9d39fc05aca855ce2abe96c407b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.