Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4505 Remove reliance on getting product version for model.zip/version.txt from FileVersionInfo and replace with using assembly custom attributes #4512

Open
wants to merge 1 commit into
base: master
from

Conversation

@r0ss88
Copy link

r0ss88 commented Nov 29, 2019

Refer to original issue for further details of the reasons for this change.

I have used AssemblyInformationalVersionAttribute to match the same behaviour as was introduced with the change to reliance of FileVersionInfo.GetVersionInfo. There is already a test covering -ModelFiles.DetermineNugetVersionFromModel in Microsoft.ML.FunctionalTests.

…from FileVersionInfo and replace with using assembly custom attributes (#4505)
@r0ss88 r0ss88 requested a review from dotnet/mlnet-core as a code owner Nov 29, 2019
@dnfclas

This comment has been minimized.

Copy link

dnfclas commented Nov 29, 2019

CLA assistant check
All CLA requirements met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.