Skip to content

Conversation

yaeldekel
Copy link

@yaeldekel yaeldekel commented May 22, 2020

In PR #5104 he hashing function of 8 byte numeric types was changed, but there still needs to be an unchanged implementation for old version models.

In addition, found a bug in ONNX conversion of hashing of keys that have underlying type different than uint.

@yaeldekel yaeldekel requested a review from a team as a code owner May 22, 2020 08:47
@yaeldekel yaeldekel requested a review from harishsk May 22, 2020 08:47
@codecov
Copy link

codecov bot commented May 24, 2020

Codecov Report

Merging #5152 into master will increase coverage by 0.01%.
The diff coverage is 82.27%.

@@            Coverage Diff             @@
##           master    #5152      +/-   ##
==========================================
+ Coverage   75.76%   75.77%   +0.01%     
==========================================
  Files         993      993              
  Lines      180746   180876     +130     
  Branches    19463    19477      +14     
==========================================
+ Hits       136944   137062     +118     
- Misses      38516    38521       +5     
- Partials     5286     5293       +7     
Flag Coverage Δ
#Debug 75.77% <82.27%> (+0.01%) ⬆️
#production 71.70% <65.00%> (-0.01%) ⬇️
#test 88.87% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Data/Transforms/Hashing.cs 81.91% <65.00%> (-0.26%) ⬇️
test/Microsoft.ML.Tests/OnnxConversionTest.cs 99.38% <100.00%> (-0.07%) ⬇️
test/Microsoft.ML.Tests/Transformers/HashTests.cs 100.00% <100.00%> (ø)
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 83.19% <0.00%> (-3.37%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.32% <0.00%> (-0.85%) ⬇️
.../Microsoft.ML.Data/DataLoadSave/Text/TextLoader.cs 82.23% <0.00%> (-0.36%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.58% <0.00%> (+0.16%) ⬆️
test/Microsoft.ML.Tests/TextLoaderTests.cs 96.26% <0.00%> (+0.51%) ⬆️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0.00%> (+1.45%) ⬆️

Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@harishsk harishsk merged commit ad07320 into dotnet:master May 26, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants