Added IDisposable to OnnxTransformer and fixed memory leaks #5348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harishsk
requested review from
michaelgsharp,
antoniovs1029,
kere-nel,
mstfbl and
frank-dong-ms-zz
Codecov Report
@@ Coverage Diff @@
## master #5348 +/- ##
=======================================
Coverage 74.04% 74.04%
=======================================
Files 1019 1019
Lines 189949 190005 +56
Branches 20429 20455 +26
=======================================
+ Hits 140651 140696 +45
+ Misses 43786 43779 -7
- Partials 5512 5530 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eerhardt
reviewed
Aug 15, 2020
antoniovs1029
approved these changes
Aug 15, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5342
A temp file was being created when the Onnx model was being loaded from within an ML.NET model. This file wasn't being deleted when the session exited because OnnxTransformer didn't support IDisposable. (Also added Dispose calls to OnnxTransformer objects in the tests)
Thanks to the reported bug, this also fixes memory leaks that we would see from OnnxRuntime.dll because the native memory associated with InferenceSession wasn't freed.