updated official build yml to latest version #5877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5877 +/- ##
==========================================
+ Coverage 68.18% 68.26% +0.07%
==========================================
Files 1142 1142
Lines 242367 242367
Branches 25355 25355
==========================================
+ Hits 165268 165440 +172
+ Misses 70414 70269 -145
+ Partials 6685 6658 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Builds not reporting status to github currently. Latest code coverage has passed Latest CI has passed: Will try to merge in tomorrow. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that the official build yml isn't validated during the PR process.
With all the new additions and use of new queues, we need to update the yml syntax from version 1 to the current version. I synced with @safern and used this doc, https://github.com/dotnet/arcade/blob/main/Documentation/AzureDevOps/PhaseToJobSchemaChange.md, to update the YAML from using the 'phase' syntax to the new 'job' syntax. This was already done for the CI build a while ago, but it hadn't been done for the official build (probably because it wasn't necessary to use the latest syntax at the time).
Here is a run with these official builds succeeding, https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4980869&view=logs&j=1d2f55de-c984-5e06-0d18-75388f298a89&t=1d2f55de-c984-5e06-0d18-75388f298a89.
I have also verified the nuget packages have the correct native files for linux-arm, linux-arm64, osx-arm64 for the 2 packages that should have them.