Skip to content

Conversation

LittleLittleCloud
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

plus fix spell error in text classification

related issue

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #6430 (ee872e5) into main (1a83389) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6430   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files        1170     1170           
  Lines      246977   247015   +38     
  Branches    25792    25793    +1     
=======================================
+ Hits       169163   169203   +40     
+ Misses      71073    71071    -2     
  Partials     6741     6741           
Flag Coverage Δ
Debug 68.49% <100.00%> (+<0.01%) ⬆️
production 62.88% <ø> (+<0.01%) ⬆️
test 88.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/Microsoft.ML.AutoML.Tests/TunerTests.cs 100.00% <100.00%> (ø)
src/Microsoft.ML.Transforms/Text/LdaTransform.cs 88.44% <0.00%> (+0.14%) ⬆️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 89.77% <0.00%> (+0.15%) ⬆️

@michaelgsharp michaelgsharp merged commit 3948211 into dotnet:main Nov 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants