Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2024

Backport of #6937 to release/3.0

/cc @michaelgsharp

Customer Impact

Improves the testing process for PR's to better facilitate us getting PR's out.

Testing

All tests pass with new changes and only test assemblies are changed.

Risk

None, only test assemblies are changed.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is failing because it's still using the old preview 3 SDK. Need to merge the SDK / arcade update PR.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f268c7) 68.80% compared to head (4f268c7) 68.80%.

❗ Current head 4f268c7 differs from pull request most recent head ba573cd. Consider uploading reports for the commit ba573cd to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           release/3.0    #6947   +/-   ##
============================================
  Coverage        68.80%   68.80%           
============================================
  Files             1240     1240           
  Lines           249601   249601           
  Branches         25509    25509           
============================================
  Hits            171738   171738           
  Misses           71262    71262           
  Partials          6601     6601           
Flag Coverage Δ
Debug 68.80% <0.00%> (ø)
production 63.27% <0.00%> (ø)
test 88.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@michaelgsharp
Copy link
Contributor

Closing so that the bot can fix the conflict now that the arcade changes are in.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants