Android gallery fixes #15118
Merged
Android gallery fixes #15118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
android_gallery_fixes
branch
from
e685594
to
e6dff8a
Compare
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
Eilon
added
the
area-infrastructure
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
rmarinho
approved these changes
May 18, 2023
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
* - fix up back button * - remove CarouselPage tests * - add missing shim extension for grid * - ignore carouselview tests * - add better testing categories * - wire up stubbed TestApp for nunit * - remove material entry tests * - remove relative layout tests * - categorize TabbedPageTests * - fix build errors * - ignore cell tests * Auto-format source code * - add ignore attributes for android * - add rest of ignores * Auto-format source code * - additional ignores * - for now ignore on both platforms * - add ignore * - add ignore * - remove platform tests from SLN --------- Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
PureWeen
added
the
backport/suggested
|
Added backport/suggested If we get the legacy gallery running on net7, I can run the current set of failing tests and see if anything is green on net7 but red on net8. |
hartez
removed
the
backport/suggested
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
IgnoreAttributeon the platform they are failing from and then just fromCategorywhere they aren't