Introduce AutomationProperties.ExcludedWithChildren #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationProperties still needs to be wired up for proper testing. For now, comment out Button and Label handler registration in AppHostBuilderExtensions
rachelkang
commented
Jul 26, 2021
| @@ -25,7 +25,7 @@ public static string SetContentDescription(this global::Android.Views.View Contr | |||
| return _defaultContentDescription; | |||
| } | |||
|
|
|||
| public static void SetFocusable(this global::Android.Views.View Control, Element Element, ImportantForAccessibility? _defaultImportantForAccessibility = null) | |||
| public static void SetImportantForAccessibility(this global::Android.Views.View Control, Element Element, ImportantForAccessibility? _defaultImportantForAccessibility = null) | |||
There was a problem hiding this comment.
Renamed to SetImportantForAccessibility because (1) focusable was a misleading name, and referred to the native focusable property that was formerly misused and (2) has since been removed. (3) The new name better reflects the method and aligns better with the naming pattern that related methods follow on both Android and iOS (of using the name of the relevant native api affected)
mattleibow
approved these changes
Jul 27, 2021
samhouts
added
the
fixed-in-6.0.100-preview.7.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Introduce
AutomationProperties.ExcludedWithChildrenproperty,AutomationProperties.ExcludedWithChildrensupplements the existingAutomationProperties.IsInaccessibleTreeby enabling developers to remove the specified control and all its children from the accessibility tree. The two properties together match up to what the XCT SemanticInclusion property offers.It maps to
ImportantForAccessibility.NoHideDescendantson Android, and toAccessibilityElementsHiddenon iOS.Additions made
AutomationProperties.ExcludedWithChildren