Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traits to iOS Checkbox so it reads as Switch #1832

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jul 27, 2021

Description of Change

iOS doesn't natively have a checkbox so to make the current checkbox more accessible we will treat it semantically like a switch

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@PureWeen PureWeen requested a review from rachelkang July 27, 2021 20:28
@PureWeen PureWeen merged commit ab7ddef into main Jul 28, 2021
@PureWeen PureWeen deleted the ios_accessible_checkbox branch July 28, 2021 02:57
@rachelkang rachelkang added the legacy-area-a11y Relates to accessibility label Aug 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon added the t/a11y Relates to accessibility label May 13, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! legacy-area-a11y Relates to accessibility t/a11y Relates to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants