Implement Safe Area handling for iOS #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
reviewed
Aug 8, 2021
| @@ -6,7 +6,7 @@ namespace Microsoft.Maui | |||
| /// Provides the base properties and methods for all Layout elements. | |||
| /// Use Layout elements to position and size child elements in .NET MAUI applications. | |||
| /// </summary> | |||
| public interface ILayout : IView, IContainer | |||
| public interface ILayout : IView, IContainer, ISafeAreaView | |||
There was a problem hiding this comment.
What is the benefit of having this on ILayout as opposed to IView?
I am thinking that for most people, a IScrollView might be the root? Also, for a game/drawn app, the root may be a canvas/graphics view?
| @@ -6,6 +6,7 @@ namespace Microsoft.Maui.Layouts | |||
| public interface ILayoutManager | |||
| { | |||
| Size Measure(double widthConstraint, double heightConstraint); | |||
| Size ArrangeChildren(Rectangle childBounds); | |||
|
|
|||
| Size ArrangeChildren(Size finalSize); | |||
There was a problem hiding this comment.
Just an FYI that this is an ABI break for P7 that may break layout implementors. So we may have to let them know before we release.
mattleibow
approved these changes
Aug 9, 2021
This was referenced Feb 15, 2023
samhouts
added
area-layout
ghost
added
the
legacy-area-controls
Eilon
removed
legacy-area-controls
samhouts
added
the
fixed-in-6.0.100-preview.7.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ISafeAreaView interface to ILayout (and to Page in Controls).
Page implements ISafeAreaView.IgnoreSafeArea via the
UseSafeAreaplatform specific.Handle safe area offset checking for LayoutView and PageView.
Also fixes incorrect parameter type for ILayoutManager.ArrangeChildren (Rectangle -> Size).