Update appium/drivers versions #22552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
previously approved these changes
May 21, 2024
Eilon
added
the
area-infrastructure
jsuarezruiz
previously approved these changes
May 22, 2024
jfversluis
reviewed
May 22, 2024
| @@ -40,27 +40,49 @@ Find the script for that on the DevDiv Azure DevOps instance, Engineering team, | |||
|
|
|||
There was a problem hiding this comment.
See lines just above here. This should ideally match what is on the agents? @rmarinho ?
There was a problem hiding this comment.
Yes we can ask @mjbond-msft to update botdeploy script.
There was a problem hiding this comment.
So my latest changes install the drivers to a local directory, so those versions won't matter to the botdeploy script, but we can ask @mjbond-msft maybe to update the appium version itself (in this case it will now be the latest 2.5.4), since that we are still globally updating.
jfversluis
reviewed
May 22, 2024
The separate doctor package is deprecated and now appium contains doctor commands for drivers and plugins:
These will get picked up by virtue of being placed in $(LogDirectory) now
We now are setting APPIUM_HOME which will point appium to where we want our drivers/plugins saved, and this directory will be inside the CI/CD working directory so it should be 'clean' every time we run this. We shouldn't ever see the uninstall driver commands run, and we shouldn't need to touch any ~/.appium* folders from other pipelines.
jfversluis
approved these changes
May 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updating appium version and driver versions to latest to see if this has a positive impact on pipeline stability