-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update appium/drivers versions #22552
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
b97b55b
Update appium/drivers versions
Redth 52148c8
Use newer .NET SDK
Redth 506d5ba
Try to uninstall appium / cleanup first
Redth b38539d
Invoke appium -v in try/catch
Redth 27e6715
Log npm into LogDirectory and verbose
Redth d603a20
Use newer appium doctor commands
Redth 50210f6
Remove added artifact stage
Redth 0e256cb
Fix logic syntax
Redth 938d758
Fix ps command for create dir
Redth aabcea1
Fix path combine for logs
Redth 6c04bac
Fix logging options
Redth 58a5957
Try ignoring appium doctor exit code
Redth 8696369
Try driver uninstall directly with npm
Redth 62c64ee
Try using update/install
Redth 2b266cd
Use same npm command appium does to install driver
Redth 921e6d8
Install drivers based on platform
Redth 0d4b4f2
Remove clearing .appium user folder
Redth 05541a3
Try setting APPIUM_HOME to a local folder
Redth 40ca010
Move variables
Redth a994681
Remove old appium cleanup
Redth 025d668
Install explicit versions
Redth 05f70e0
List out appium home dir, not npm logs
Redth e1956e1
Merge branch 'main' into dev/redth/appium-install
Redth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See lines just above here. This should ideally match what is on the agents? @rmarinho ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can ask @mjbond-msft to update botdeploy script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my latest changes install the drivers to a local directory, so those versions won't matter to the botdeploy script, but we can ask @mjbond-msft maybe to update the appium version itself (in this case it will now be the latest 2.5.4), since that we are still globally updating.